Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20725 )
Change subject: KUDU-3527 Fix block manager test on 64k filesystems ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/20725/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20725/5//COMMIT_MSG@7 PS5, Line 7: Fix block manager test on 64k filesystems > Could you give more detail about the test on system where f_bsize=64k? For f_bsize=64k, I do the following. Start an rhel 8.8 with 64k kernel. Mount an additional disk and format it: mkfs.xfs -b /dsize=65536 -f /dev/<disk> (to my best understanding you should prefer using such formating with 64k kernel or use the 4k kernel version of rhel arm). mount it and put kudu data dir on it (export TEST_TMPDIR=/mnt/disk2/kudu_test) you will have f_bsize=64k and st_blksize=64k. Kudu wont start because “Status CheckHolePunch(…)” in dir_util.cc has hardcoded values (also needs fixing). I took a deeper look at https://gerrit.cloudera.org/#/c/20680/. I think I finally start to understand the problem. Your fix is necessary (f_bsize is indeed what hole punch/ preallocation uses). However it is just one of multiple fixes that are needed. I suggest we continue the discussion in 20680 For the fix in this request: Fixing the “f_bsize > 4k || st_blksize > 4k” problem wont fix BlockManagerTest.TestMetadataOkayDespiteFailure. It will still fail for f_bsize=64k disk (as it does even on x86_64 with minor changes). I thing we should mere this fix, as it is just accidentally correlated with the f_bsize issues. However if you guys would like to keep it open until other issues are fixed, and we can test it on f_bsize=64k system, then we can leave it open. -- To view, visit http://gerrit.cloudera.org:8080/20725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e325bde502b7d7f39dd17fa84cb7eb42a3d7c20 Gerrit-Change-Number: 20725 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Thu, 14 Dec 2023 12:52:32 +0000 Gerrit-HasComments: Yes
