Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20720 )
Change subject: [compaction/flush] Cleanup of compaction and flush code paths ...................................................................... Patch Set 4: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/20720/4/src/kudu/tablet/compaction.h File src/kudu/tablet/compaction.h: http://gerrit.cloudera.org:8080/#/c/20720/4/src/kudu/tablet/compaction.h@118 PS4, Line 118: const nit: alignment http://gerrit.cloudera.org:8080/#/c/20720/4/src/kudu/tablet/compaction.h@121 PS4, Line 121: compaction Also update the comments. http://gerrit.cloudera.org:8080/#/c/20720/4/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: http://gerrit.cloudera.org:8080/#/c/20720/4/src/kudu/tablet/compaction.cc@1388 PS4, Line 1388: // Following method processes the compaction input by reading input rows in : // blocks and for each row inside the block: : // - Apply all REDO mutations collected for the row at hand : // - Generate corresponding UNDO deltas for applied mutations : // - For a row with 'ghost' entries, merge their histories of mutations : // - Remove any ancient UNDO mutations, as those are not applicable anymore : // - Append UNDO and REDO deltas to DiskRowSetWriter output : // - Append fully or partially (resized) processed rowblock to DRS writer output Instead of writing comments at the head of function, I'd prefer to palce these steps comments separately and closer to the code where it describe. The benifits are it would be more readability and the comments can be updated in time when the related code update. http://gerrit.cloudera.org:8080/#/c/20720/4/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/20720/4/src/kudu/tablet/tablet.cc@2061 PS4, Line 2061: entries nit: Add a dot at the end. Other places are the same. -- To view, visit http://gerrit.cloudera.org:8080/20720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1c2f20230aa089baf34f418a59b6c97f7351217 Gerrit-Change-Number: 20720 Gerrit-PatchSet: 4 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 15 Dec 2023 07:37:42 +0000 Gerrit-HasComments: Yes
