Abhishek Chennaka has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/20808 )
Change subject: [tserver] unify logging on rejected write requests
......................................................................
[tserver] unify logging on rejected write requests
This patch contain a minor clean up on the logging of rejected write
requests and other minor improvements, making the logs more useful
for post-mortem analysis and troubleshooting in some scenarios:
* unified the prefix for log messages on rejected write requests,
so it's now easier to search in the logs
* log about all rejected write requests using time-based throttling
wrapper KLOG_EVERY_N_SECS(.., 1)
* log about all rejected write requests using INFO severity unless
going over the --memory_limit_warn_threshold_percentage threshold
for memory pressure rejections; use WARNING severity for the latter
* changed TabletServerErrorPB from UNKNOWN_ERROR to THROTTLED when
rejecting a write request due to a throttling condition
* use static instances of Status objects to avoid allocating and
freeing memory for status messages upon rejections
Change-Id: I2ef97c54815b8d2e1895ce884befc7daf3d550f4
Reviewed-on: http://gerrit.cloudera.org:8080/20808
Tested-by: Kudu Jenkins
Reviewed-by: Abhishek Chennaka <[email protected]>
---
M src/kudu/tserver/tablet_service.cc
1 file changed, 41 insertions(+), 29 deletions(-)
Approvals:
Kudu Jenkins: Verified
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/20808
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ef97c54815b8d2e1895ce884befc7daf3d550f4
Gerrit-Change-Number: 20808
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
