Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20831 )
Change subject: [rpc] extra test scenarios for exactly-once RPC logic ...................................................................... [rpc] extra test scenarios for exactly-once RPC logic In the context of troubleshooting one issue, it was necessary to know how the exactly-once RPC logic handles the re-ordering of RPC requests, so I added these extra scenarios to make sure the implementation behaves as expected. I think it's worth it adding the new tests into the code base to explicitly state how the system behaves in particular cases and to catch possible regressions if the corresponding code modified in the future. Change-Id: I3eedeb786420175b604fc67a9de948cedba9c53a Reviewed-on: http://gerrit.cloudera.org:8080/20831 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Abhishek Chennaka <[email protected]> --- M src/kudu/rpc/exactly_once_rpc-test.cc 1 file changed, 187 insertions(+), 16 deletions(-) Approvals: Alexey Serbin: Verified Abhishek Chennaka: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/20831 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3eedeb786420175b604fc67a9de948cedba9c53a Gerrit-Change-Number: 20831 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
