Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20830 )
Change subject: Do not enter ALTERING state just for replication factor changed. ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/20830/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20830/2//COMMIT_MSG@9 PS2, Line 9: If we change the replication factor of a table without any tablets, : the table will stay in ALTERING state since exiting this state needs : tablet reports from the tablets of this table Do you mind adding a small test scenario for this to make sure the bug is fixed and to track future regressions? http://gerrit.cloudera.org:8080/#/c/20830/2//COMMIT_MSG@17 PS2, Line 17: num number http://gerrit.cloudera.org:8080/#/c/20830/2//COMMIT_MSG@17 PS2, Line 17: the check of : tablet number is also needed how about: the applicability of the changes for existing replicas is already accounted for by the 'table->num_tablets() > tablets_to_drop.size()' condition. -- To view, visit http://gerrit.cloudera.org:8080/20830 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d20da7c0dd5912790aaa46e9fff366b2973d7a4 Gerrit-Change-Number: 20830 Gerrit-PatchSet: 2 Gerrit-Owner: Song Jiacheng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 23 Dec 2023 00:13:25 +0000 Gerrit-HasComments: Yes
