Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20830 )
Change subject: Do not enter ALTERING state just for replication factor changed. ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/20830/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20830/9//COMMIT_MSG@10 PS9, Line 10: state Add: until the request timeout. http://gerrit.cloudera.org:8080/#/c/20830/9/src/kudu/integration-tests/alter_table-test.cc File src/kudu/integration-tests/alter_table-test.cc: http://gerrit.cloudera.org:8080/#/c/20830/9/src/kudu/integration-tests/alter_table-test.cc@2642 PS9, Line 2642: TEST_F(ReplicatedAlterTableTest, CheckTableStateAfterReplicatedAlter) { How about use TEST_P to test the case also: without the fix, alter replica factor will timeout? -- To view, visit http://gerrit.cloudera.org:8080/20830 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d20da7c0dd5912790aaa46e9fff366b2973d7a4 Gerrit-Change-Number: 20830 Gerrit-PatchSet: 9 Gerrit-Owner: Song Jiacheng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Song Jiacheng <[email protected]> Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Comment-Date: Thu, 04 Jan 2024 09:19:17 +0000 Gerrit-HasComments: Yes
