Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20846 )
Change subject: [WIP] Increase AssertEventually timeout to 60 seconds ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/20846/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20846/3//COMMIT_MSG@10 PS3, Line 10: After Checking the code thoroughly, it looked : like the code worked fine, it failed because of slow execution. Could you be more specific here, in particular: * what exact tests failed because of this * what was the build configurations for the binaries (DEBUG/RELEASE/ASAN/TSAN) that used to run the failing tests http://gerrit.cloudera.org:8080/#/c/20846/3//COMMIT_MSG@12 PS3, Line 12: AssertEventually timeout is increased to 60 seconds I'm not sure that's a good resolution for the issue. For the majority of the cases in our current test set, 30 seconds is more than enough: I'd rather try to understand what exact tests are timing out. Most likely, 30 seconds isn't enough either because of a bug/flakiness or running the test under TSAN. I'd rather update the timeout for particular instances of AssertEventually usage, not this sort of blanket change. -- To view, visit http://gerrit.cloudera.org:8080/20846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84349435a0c9b3efeb4fc37b5f7fab4a0f505a1c Gerrit-Change-Number: 20846 Gerrit-PatchSet: 3 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 04 Jan 2024 17:09:53 +0000 Gerrit-HasComments: Yes
