Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20855 )
Change subject: [log] use THROTTLE_MSG for KLOG_EVERY_N_SECS when necessary ...................................................................... [log] use THROTTLE_MSG for KLOG_EVERY_N_SECS when necessary As a follow-up to e8f459284 and 8bc0be58e, this patch updates call sites of KLOG_EVERY_N_SECS w.r.t. using THROTTLE_MSG to report on the number of suppressed messages. The rationale behind this update is to provide extra information that is useful for troubleshooting, according to my findings while troubleshooting a few recent issues. In addition, I added one micro-test for KLOG_EVERY_N_SECS when used without THROTTLE_MSG and removed useless logging in another test: it seems the logging was added there just for debugging while implementing the test. I also took the liberty of updating corresponding messages and the logging frequency to be more appropriate. Otherwise, this patch doesn't contain any functional modifications. Change-Id: I1ef2952b86b15f15cd8cd806619e5113ad1c758f Reviewed-on: http://gerrit.cloudera.org:8080/20855 Tested-by: Kudu Jenkins Reviewed-by: Abhishek Chennaka <achenn...@cloudera.com> --- M src/kudu/master/master_service.cc M src/kudu/master/ts_manager.cc M src/kudu/rpc/proxy.cc M src/kudu/rpc/server_negotiation.cc M src/kudu/security/token-test.cc M src/kudu/security/token_verifier.cc M src/kudu/tablet/rowset_info.cc M src/kudu/tablet/tablet_replica.cc M src/kudu/thrift/sasl_client_transport.cc M src/kudu/util/logging-test.cc M src/kudu/util/maintenance_manager.cc 11 files changed, 67 insertions(+), 31 deletions(-) Approvals: Kudu Jenkins: Verified Abhishek Chennaka: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/20855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1ef2952b86b15f15cd8cd806619e5113ad1c758f Gerrit-Change-Number: 20855 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120)
