Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20899 )
Change subject: [log_block_manager-test] Improve random selection ...................................................................... Patch Set 4: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/20899/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20899/4//COMMIT_MSG@9 PS4, Line 9: because it : was possible that way less blocks are removed than expected I got what you mean. Could you also give more detail to explain why the previous solution maybe cause this problem. http://gerrit.cloudera.org:8080/#/c/20899/4/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/20899/4/src/kudu/fs/log_block_manager-test.cc@1298 PS4, Line 1298: ids.erase(ids.begin(), ids.begin() + static_cast<int>(kLiveBlockRatio * kNumBlocks)); Is it better to use another variable to store the to-delete ids, for example `to_deleted_ids`? `ids` may be used in other place later. -- To view, visit http://gerrit.cloudera.org:8080/20899 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f73f0572319784b07845b02d15a7d3e6f31abce Gerrit-Change-Number: 20899 Gerrit-PatchSet: 4 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Comment-Date: Tue, 16 Jan 2024 04:03:17 +0000 Gerrit-HasComments: Yes
