Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20894 )
Change subject: Fix CheckHolePunch for bigger than 4k blocks. ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/20894/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20894/2//COMMIT_MSG@12 PS2, Line 12: > Maybe you could add more details on what fails in this test if underlying f I just wanted to give a test, so if some1 wants to try it out, he does not have to run a whole server. I changed the commit message, so It wont confuse anyone. It is not a unit test fix. This is required for kudu to start http://gerrit.cloudera.org:8080/#/c/20894/1/src/kudu/fs/dir_util.cc File src/kudu/fs/dir_util.cc: http://gerrit.cloudera.org:8080/#/c/20894/1/src/kudu/fs/dir_util.cc@78 PS1, Line 78: ETURN_NOT_OK(env->GetBlockSize(filename, > There are some failed tests, please check it. Thank you. http://gerrit.cloudera.org:8080/#/c/20894/2/src/kudu/fs/dir_util.cc File src/kudu/fs/dir_util.cc: http://gerrit.cloudera.org:8080/#/c/20894/2/src/kudu/fs/dir_util.cc@a68 PS2, Line 68: > Just wondering, if we keep offset at 4K which is unaligned for a 64K file-s We use ioctl in case of xfs. (see Status PunchHole in env_posix.cc) It does not report any error. Currently we fail with error message in line 96. (since file will be 64k). If we reserve a multiple of 64k, but make an unaligned or not long enough hole punch, then we fail with the message in line 105. -- To view, visit http://gerrit.cloudera.org:8080/20894 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4af73f0aa25db674fe0a34355cecd27a0c68417 Gerrit-Change-Number: 20894 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 16 Jan 2024 11:00:51 +0000 Gerrit-HasComments: Yes
