Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20917
Change subject: KUDU-3491 Destruct master before creating a new one ...................................................................... KUDU-3491 Destruct master before creating a new one ServerBase constructor runs MinidumpExceptionHandler constructor that calls RegisterMinidumpExceptionHandler(). This function increments the static atomic variable current_num_instances_. Then the ServerBase is destructed, a similar process happens and current_num_instances_ gets decremented. If current_num_instances_ is not zero before incrementing or not 1 before decrementing, then it is considered an error. This indicates that only one Server can run at any given time. But in case of multi-master config, the master server is replaced, and without the change it is possible that the second server's constructor precede first server's destructor. This change makes it sure that the destructor is executed before the second one's constructor. Change-Id: I3c1019d092bbf9e58f4fc33753a1218bc79735d3 Reviewed-on: http://gerrit.cloudera.org:8080/20913 Reviewed-by: Attila Bukor <[email protected]> Reviewed-by: Mahesh Reddy <[email protected]> Tested-by: Kudu Jenkins (cherry picked from commit 7562277fc6f68b0dcab593d56de03bb344a95b3e) --- M src/kudu/master/dynamic_multi_master-test.cc M src/kudu/master/master_runner.cc 2 files changed, 43 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/20917/1 -- To view, visit http://gerrit.cloudera.org:8080/20917 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: newchange Gerrit-Change-Id: I3c1019d092bbf9e58f4fc33753a1218bc79735d3 Gerrit-Change-Number: 20917 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ádám Bakai <[email protected]>
