Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20715 )
Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client. ...................................................................... Patch Set 28: Code-Review+2 (3 comments) Thank you very much for the fix! http://gerrit.cloudera.org:8080/#/c/20715/19//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20715/19//COMMIT_MSG@10 PS19, Line 10: It is because that scanner does not bind with the : tserver with which it first communicates. > This problem is triggered when getReplicaSelectedServerInfo cound not find Yep, that makes sense to me. Thank you for clarifying. http://gerrit.cloudera.org:8080/#/c/20715/19/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java File java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java: http://gerrit.cloudera.org:8080/#/c/20715/19/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java@308 PS19, Line 308: tablet server > Sorry, I'm also very confused how it came from. Maybe, that was from the very early revisions when the terminology wasn't quite flushed out yet. Thank you for fixing these comments! http://gerrit.cloudera.org:8080/#/c/20715/19/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/20715/19/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@670 PS19, Line 670: HostAndPort targetHp = harness.findLeaderTabletServer(targetTablet); : return !targetHp.equals(referenceServerHostPort); > These two operations, demoteLeader() and emptyTabletsCacheForTable() , are OK, now I see the intent behind this comment. Thank you for clarifying. -- To view, visit http://gerrit.cloudera.org:8080/20715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cf65f4215e99198dd41b43d14e50c8c23b8a9b2 Gerrit-Change-Number: 20715 Gerrit-PatchSet: 28 Gerrit-Owner: Song Jiacheng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Song Jiacheng <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Thu, 18 Jan 2024 23:41:38 +0000 Gerrit-HasComments: Yes
