Ádám Bakai has posted comments on this change. (
http://gerrit.cloudera.org:8080/20940 )
Change subject: [docs] Expand master add argument list
......................................................................
Patch Set 1:
I figured out what was the difference: I'm using non-default port numbers.
(Because I'm executing multiple kudu-masters at the same machine.) If I'm using
the default port for the new master, it works kinda, but not perfectly. I added
debug message to the CheckMasterVoterAndHealthy:
for (const auto& master_hp : master.registration().rpc_addresses()) {
LOG(INFO)<<"compare hosts"<<new_master_hp.ToString()<<" "<<
HostPortFromPB(master_hp).ToString();
if (new_master_hp == HostPortFromPB(master_hp)) {
// Found the newly added master
new_master_found = true;
break;
And the output is:
I20240124 16:35:35.406461 2026766 tool_action_master.cc:312] compare hosts
127.0.0.1:7051 adam-7070-ubuntu:7051
and obviously the string comparision will fail, eventhough the adding was
successful. (It works fine, if I'm using adam-7070-ubuntu instead of 127.0.0.1)
I will create an upstream ticket about this, and change this review to warning
that if non-default port is used, then rpc-bind-address argument is needed.
--
To view, visit http://gerrit.cloudera.org:8080/20940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b7a07ca072c9a8d09aa0f70ff643f8f11cbd389
Gerrit-Change-Number: 20940
Gerrit-PatchSet: 1
Gerrit-Owner: Ádám Bakai <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Ádám Bakai <[email protected]>
Gerrit-Comment-Date: Wed, 24 Jan 2024 15:49:59 +0000
Gerrit-HasComments: No
