Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20958 )
Change subject: [WIP][catalog_manager] Skip eviction during bootstrapping ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/20958/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20958/6//COMMIT_MSG@10 PS6, Line 10: During this time, it is possible to send a full : tablet report it still reckons itself as the leader and since it is : bootstrapping Oh, really? I thought ReportedTabletPB::consensus_state isn't present when the state of the tablet is BOOTSTRAPPING, but I might be missing something. I'd think we saw the DCHECK() triggering much more often if that was the root cause. The situation described here happens every time upon bootstrapping a tablet replica that has been a leader in prior incarnation, especially if it has a lot of data. However, that's not the case. Are you sure your analysis is correct? http://gerrit.cloudera.org:8080/#/c/20958/6//COMMIT_MSG@15 PS6, Line 15: There is no need for new test : because this change fixes ToolTest::TestRecreateCMeta flakiness and : verifies the correct behaviour indirectly. I'm not sure this makes sense to me. The issue that was triggering the DCHECK() in quorum_utils.cc was happening extremely rare. With that, how do you know that your analysis is correct if you don't have a test that at least allows for the reproduction of the issue on a regular basis, so you could see if the fix is working? -- To view, visit http://gerrit.cloudera.org:8080/20958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0cbbe6b77d99d167fc58692047072f86d3d963cf Gerrit-Change-Number: 20958 Gerrit-PatchSet: 6 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 02 Feb 2024 05:27:03 +0000 Gerrit-HasComments: Yes
