Hello Marton Greber, Attila Bukor,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/21007
to review the following change.
Change subject: KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges
......................................................................
KUDU-3549 fix WriteAsPrometheus() for non-arithmetic gauges
This patch fixes WriteAsPrometheus() implementation for string-based
gauges. The original changelist that introduced Prometheus metrics
had a proper implementation of WriteAsPrometheus() only for StringGauge,
but any FunctionGauge for a non-arithmetic type (e.g., for std::string)
would still output a string value in Prometheus text format, and that
could not be consumed by Prometheus. The patch also contains a test
scenario that would fail without the fix.
This is a follow-up to 00efc6826ac9a1f5d10750296c7357790a041fec.
Change-Id: Ib7128f52729c7f984004811153a7eecc8ffe751b
Reviewed-on: http://gerrit.cloudera.org:8080/20990
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Marton Greber <[email protected]>
Reviewed-by: Attila Bukor <[email protected]>
(cherry picked from commit 6b1c1eb0c97a2349e0b3fa098bf40f8147b43a60)
Conflicts:
src/kudu/util/metrics.cc
src/kudu/util/metrics.h
---
M src/kudu/util/metrics-test.cc
M src/kudu/util/metrics.cc
M src/kudu/util/metrics.h
3 files changed, 98 insertions(+), 71 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/21007/1
--
To view, visit http://gerrit.cloudera.org:8080/21007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib7128f52729c7f984004811153a7eecc8ffe751b
Gerrit-Change-Number: 21007
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Marton Greber <[email protected]>
