Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 )
Change subject: KUDU-613: Introduce SLRU cache ...................................................................... Patch Set 10: (4 comments) Just glanced over the tests, and there is one question I'd like to clarify before going over the rest of the code. http://gerrit.cloudera.org:8080/#/c/20607/10/src/kudu/util/slru_cache-test.cc File src/kudu/util/slru_cache-test.cc: http://gerrit.cloudera.org:8080/#/c/20607/10/src/kudu/util/slru_cache-test.cc@76 PS10, Line 76: nit: the indent should be 2 + 4 = 6 spaces here http://gerrit.cloudera.org:8080/#/c/20607/10/src/kudu/util/slru_cache-test.cc@80 PS10, Line 80: { } nit: wrong indent http://gerrit.cloudera.org:8080/#/c/20607/10/src/kudu/util/slru_cache-test.cc@209 PS10, Line 209: RETURN_IF_NO_NVM_CACHE(GetParam().first); Here and below: does it mean the test is run only on NVM cache? If so, how to test SLRU cache on DRAM then? And why running/skipping SLRU-related tests is predicated in NVM cache presence at all? http://gerrit.cloudera.org:8080/#/c/20607/10/src/kudu/util/slru_cache-test.cc@244 PS10, Line 244: Erase Does it make sense to test the erase operation for both the cases when an entry is in probationary and protected segments? -- To view, visit http://gerrit.cloudera.org:8080/20607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45531534a2049dd38c002f4dc7982df9fd46e0bb Gerrit-Change-Number: 20607 Gerrit-PatchSet: 10 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 08 Feb 2024 06:12:33 +0000 Gerrit-HasComments: Yes
