Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21022 )
Change subject: [tests] make token_signer-itest more robust ...................................................................... Patch Set 1: > LGTM. Maybe a different approach could be to increase > FLAGS_tsk_rotation_seconds to a very big value for these tests. Right, that one of the options. However, how high should we set that value to? And if we set it to such a high values, if the test is run even slower, then the issue will trigger again. But with the current approach in this patch, the timing issue is fixed in an ultimate way, so no flakiness is now possible in this context (but something else might break, of course :) ) -- To view, visit http://gerrit.cloudera.org:8080/21022 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8cb3a5d3ca42546073370be42459f4f03dd725cb Gerrit-Change-Number: 21022 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Fri, 09 Feb 2024 20:55:40 +0000 Gerrit-HasComments: No
