Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/20961 )
Change subject: [rpc] validate security-related parameters earlier
......................................................................
[rpc] validate security-related parameters earlier
This patch removes the verification of a few security-related RPC flags
from the connection negotiation time (i.e. DoServerNegotiation()) since
that's already done in one of the group flag validators.
Apparently, this way it's more optimal:
* misconfiguration are spotted earlier: if this type of issue
is detected, the outcome is visible and actionable outright since
the server simply refuses to start, reporting on the issue
* there isn't a way to have a Kudu server running with such an issue
* some amount of CPU resources is spared since a server no longer
performs the same verification over and over again when establishing
a new RPC connection, but performs it once during the start-up time
Change-Id: Ie16537c440041c9ee74276da35f2599592ef7e04
Reviewed-on: http://gerrit.cloudera.org:8080/20961
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Abhishek Chennaka <[email protected]>
---
M src/kudu/integration-tests/CMakeLists.txt
A src/kudu/integration-tests/security-flags-itest.cc
M src/kudu/rpc/negotiation.cc
3 files changed, 117 insertions(+), 7 deletions(-)
Approvals:
Alexey Serbin: Verified
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/20961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie16537c440041c9ee74276da35f2599592ef7e04
Gerrit-Change-Number: 20961
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Wang Xixu <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
