Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21089 )
Change subject: [Tool] Return not OK status when copying tablets failed ...................................................................... Patch Set 4: Verified+1 (1 comment) unrelated test failures: * ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks * HmsConfigurations/AlterTableRandomized.TestRandomSequence/0 http://gerrit.cloudera.org:8080/#/c/21089/2/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/21089/2/src/kudu/tools/kudu-tool-test.cc@9555 PS2, Line 9555: // An attempt to copy a non-existent tablet fails, and the r > mini_cluster_->mini_tablet_server(1) must be shutdown when copying a tablet Ah, I see, sure -- thanks for the clarification. It wasn't quite obvious, so would be great to have a comment on this in the code :) -- To view, visit http://gerrit.cloudera.org:8080/21089 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic957cbc379645e0607c1c2a3bc568e20afc126b2 Gerrit-Change-Number: 21089 Gerrit-PatchSet: 4 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Comment-Date: Fri, 01 Mar 2024 05:22:26 +0000 Gerrit-HasComments: Yes
