Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21073 )
Change subject: Remove the replace flag if the move fails in auto rebalancing. ...................................................................... Patch Set 7: (2 comments) Can you also add some tests? Thanks! http://gerrit.cloudera.org:8080/#/c/21073/7/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/21073/7/src/kudu/master/auto_rebalancer.cc@423 PS7, Line 423: move_info.leader_uuid = leader_uuid; Where is this field used? http://gerrit.cloudera.org:8080/#/c/21073/7/src/kudu/rebalance/rebalancer.h File src/kudu/rebalance/rebalancer.h: http://gerrit.cloudera.org:8080/#/c/21073/7/src/kudu/rebalance/rebalancer.h@157 PS7, Line 157: HostPort leader_hp; nit: can you add a comment describing the purpose of the new fields? -- To view, visit http://gerrit.cloudera.org:8080/21073 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99dafa654878b9d6d8162d84500913ae0655692b Gerrit-Change-Number: 21073 Gerrit-PatchSet: 7 Gerrit-Owner: Song Jiacheng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 04 Mar 2024 19:17:52 +0000 Gerrit-HasComments: Yes
