Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21075 )
Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata (2nd try) ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/21075/6/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/21075/6/thirdparty/build-definitions.sh@1213 PS6, Line 1213: DWITH_LZ4=OFF > Does this mean we don't need LZ4 support for our usage pattern of RocksDB, It's just some issue to build rocksdb to pickup LZ4. And it seems the issue just occured on the 1.9.4 version of LZ4 (release on Aug 16, 2022), when I try to build the lastest version from github.com/lz4/lz4, there is no problem, we can add LZ4 back when its next version released. (I reproduced and fixed these issues on my M1 MacBookPro, didn't reproduce that on my CentOS docker environment. -- To view, visit http://gerrit.cloudera.org:8080/21075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23b7d2a16802af01a382a1d74cd9869baf364688 Gerrit-Change-Number: 21075 Gerrit-PatchSet: 6 Gerrit-Owner: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Wed, 20 Mar 2024 15:53:44 +0000 Gerrit-HasComments: Yes
