Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21212 )
Change subject: [rpc] relax settings for MeasureAcceptorDispatchTimes ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21212/1/src/kudu/rpc/rpc-bench.cc File src/kudu/rpc/rpc-bench.cc: http://gerrit.cloudera.org:8080/#/c/21212/1/src/kudu/rpc/rpc-bench.cc@354 PS1, Line 354: for (auto i = 0; i < threads_num; ++i) { > Do we want to get rid of this loop and modify other areas of this test sinc As you could see from the commit description, the change in the default setting for 'client_threads' is just to conserve computational resources when running this test as a part of pre-commit verification make this test passing even with lower setting of 'ulimit -n'. However, rpc-bench is also used in various benchmarks. For the latter, we this test scenario provides much more insights on performance if run with multiple client threads. With --client_threads=1 it just does basic verification of the 'reactor_active_latency_us' metric. -- To view, visit http://gerrit.cloudera.org:8080/21212 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9af59046d6bcf28134cc88e7ff9e54643efc37f Gerrit-Change-Number: 21212 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 28 Mar 2024 16:27:03 +0000 Gerrit-HasComments: Yes
