Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21226 )
Change subject: KUDU-3561 skip tablet entities in Prometheus format ...................................................................... KUDU-3561 skip tablet entities in Prometheus format Currently, the Prometheus metrics writer outputs only server-level metrics. Prior to this patch, the Prometheus metrics writer would output a warning message for every tablet it encounters while iterating through all the existing metric entities. This patch addresses the issue: the tablet entries are now silently skipped, as they should. I also added a TODO for KUDU-3563 to output tablet-level metrics in Prometheus format as well. Change-Id: I618bbc2caab7a8d9812eeaeb67ac42b0293b0654 Reviewed-on: http://gerrit.cloudera.org:8080/21226 Reviewed-by: Mahesh Reddy <[email protected]> Reviewed-by: Abhishek Chennaka <[email protected]> Tested-by: Alexey Serbin <[email protected]> --- M src/kudu/util/metrics.cc 1 file changed, 31 insertions(+), 20 deletions(-) Approvals: Mahesh Reddy: Looks good to me, but someone else must approve Abhishek Chennaka: Looks good to me, approved Alexey Serbin: Verified -- To view, visit http://gerrit.cloudera.org:8080/21226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I618bbc2caab7a8d9812eeaeb67ac42b0293b0654 Gerrit-Change-Number: 21226 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]>
