Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/21241 )
Change subject: [c++17] address std::move() warnings
......................................................................
[c++17] address std::move() warnings
This patch addresses warnings about unqualified calls to std::move()
produced by CLANG15. For more context, discussion, and references,
see [1]. As a part of this patch, follow-up warnings issued by IWYU
and TidyBot are addressed as well.
Prior to this patch, there were many warnings output when compiling
the project with CLANG from Xcode 15.3 on macOS Sonoma, for example:
src/kudu/codegen/module_builder.cc:334:26: warning: unqualified call to
'std::move' [-Wunqualified-std-cast-call]
EngineBuilder ebuilder(move(module_));
^
std::
This patch doesn't contain any functional modifications.
[1] https://reviews.llvm.org/D119670?id=408276
Change-Id: Id05c4d002fabc5fbd6d7b9cc8b886ddc7a8da0a1
Reviewed-on: http://gerrit.cloudera.org:8080/21241
Reviewed-by: Mahesh Reddy <[email protected]>
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Abhishek Chennaka <[email protected]>
---
M src/kudu/client/scan_predicate.cc
M src/kudu/codegen/module_builder.cc
M src/kudu/common/column_predicate.cc
M src/kudu/common/partition_pruner.cc
M src/kudu/common/scan_spec.cc
M src/kudu/hms/hms_catalog.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/ranger/ranger_client-test.cc
M src/kudu/ranger/ranger_client.cc
M src/kudu/rpc/outbound_call.cc
M src/kudu/rpc/result_tracker.cc
M src/kudu/security/ca/cert_management.cc
M src/kudu/security/ca/cert_management.h
M src/kudu/tools/tool_action_fs.cc
M src/kudu/tools/tool_action_local_replica.cc
M src/kudu/util/block_bloom_filter-test.cc
16 files changed, 68 insertions(+), 79 deletions(-)
Approvals:
Mahesh Reddy: Looks good to me, but someone else must approve
Alexey Serbin: Verified
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/21241
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id05c4d002fabc5fbd6d7b9cc8b886ddc7a8da0a1
Gerrit-Change-Number: 21241
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
