Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21243 )
Change subject: KUDU-3564: Fix IN list predicate pruning ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/21243/1/src/kudu/common/scan_spec-test.cc File src/kudu/common/scan_spec-test.cc: http://gerrit.cloudera.org:8080/#/c/21243/1/src/kudu/common/scan_spec-test.cc@102 PS1, Line 102: [colu > nit: could use structured binding here? Done http://gerrit.cloudera.org:8080/#/c/21243/1/src/kudu/common/scan_spec-test.cc@105 PS1, Line 105: [colu > ditto Done http://gerrit.cloudera.org:8080/#/c/21243/1/src/kudu/common/scan_spec-test.cc@110 PS1, Line 110: [col_names, num_buckets] > nit: could use structural binding instead for this 'for()' cycle as well? Done http://gerrit.cloudera.org:8080/#/c/21243/1/src/kudu/common/scan_spec-test.cc@998 PS1, Line 998: : // Set lower and upper bound for 'spec' to imitate a scan request from client that : // has start_primary_key and stop_primary_key. : KuduPartialRow lower_bound(&schema_); : CHECK_OK(lower_bound.SetInt8("a", -128)); : CHECK_OK(lower_bound.SetInt8("b", > What is this for? The DCHECK in 'column_predicate.cc' was hit when running queries to reproduce the bug. Setting lower and upper bounds for 'spec' is to hit the DCHECK. -- To view, visit http://gerrit.cloudera.org:8080/21243 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I964b1ccfb85602741843ab555cdee53343217033 Gerrit-Change-Number: 21243 Gerrit-PatchSet: 2 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Sun, 07 Apr 2024 03:14:40 +0000 Gerrit-HasComments: Yes
