Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/21275 )
Change subject: Skip unhealthy directories when opening DirManager
......................................................................
Patch Set 2: Verified-1
There is at least one test that fails with this patch, and the failure look
quite relevant:
[ RUN ] DataDirManagerTest.TestOpenWithFailedDirs
E20240409 19:53:09.965541 3972253 env_posix.cc:432] I/O error, context: INJECTED
FAILURE
E20240409 19:53:09.970788 3972253 env_posix.cc:432] I/O error, context: INJECTED
FAILURE
/root/Projects/kudu/src/kudu/fs/data_dirs-test.cc:496: Failure
Expected equality of these values:
1
dd_manager_->GetFailedDirs().size()
Which is: 0
I20240409 19:53:09.976843 3972253 test_util.cc:175] ----------------------------
-------------------
I20240409 19:53:09.976894 3972253 test_util.cc:176] Had fatal failures, leaving
test files at /tmp/kudutest-0/data_dirs-test.0.DataDirManagerTest.TestOpenWithFa
iledDirs.1712717589835997-3972253-0
[ FAILED ] DataDirManagerTest.TestOpenWithFailedDirs (18 ms)
--
To view, visit http://gerrit.cloudera.org:8080/21275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If19d7a6eba9e755bcc81cca207f7c84a7837b07b
Gerrit-Change-Number: 21275
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Wed, 10 Apr 2024 03:18:54 +0000
Gerrit-HasComments: No
