Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21276 )
Change subject: [tablet] one less memory allocation in CBTree::count() ...................................................................... [tablet] one less memory allocation in CBTree::count() While reviewing [1], I noticed there is room for improvement in CBTree. One trivial one is avoiding calls to 'new' when an object might be allocated on the stack. This makes sense since in some intensive Kudu workloads we might see significant lock contention in tcmalloc, and removing needless calls to 'new' helps to relieve that, even if it's not in the hot path. [1] https://gerrit.cloudera.org/#/c/21127/ Change-Id: I01a68e0427b399db92b33c910185654d195150a5 Reviewed-on: http://gerrit.cloudera.org:8080/21276 Reviewed-by: Yingchun Lai <[email protected]> Reviewed-by: Yifan Zhang <[email protected]> Tested-by: Alexey Serbin <[email protected]> --- M src/kudu/tablet/concurrent_btree.h 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Yingchun Lai: Looks good to me, approved Yifan Zhang: Looks good to me, approved Alexey Serbin: Verified -- To view, visit http://gerrit.cloudera.org:8080/21276 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I01a68e0427b399db92b33c910185654d195150a5 Gerrit-Change-Number: 21276 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]>
