Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21272 )
Change subject: KUDU-3433 Fix flakiness in ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks ...................................................................... KUDU-3433 Fix flakiness in ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks The reason for the flakiness of the unit test is that we did not consider corner cases, namely, the time reserved from detecting a table in soft-deleted state until the execution of deletion, during which some operations may occur. We need to reserve more time. However, in order to verify that FLAGS_table_reserve_seconds is indeed effective, the additional time cannot be too long. Taking these two factors into consideration, I added one second of waiting time and performed multiple tests locally using the gtest_repeat parameter to ensure that this modification is effective. Change-Id: Iab3a6a5f54701470e368c043133f4646aa71126d Reviewed-on: http://gerrit.cloudera.org:8080/21268 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> (cherry picked from commit e5f3d2b19e7a210f64e76584fbe53454886668cb) Reviewed-on: http://gerrit.cloudera.org:8080/21272 Reviewed-by: Yingchun Lai <[email protected]> --- M src/kudu/client/client-test.cc 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Yingchun Lai: Looks good to me, approved Alexey Serbin: Verified -- To view, visit http://gerrit.cloudera.org:8080/21272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: merged Gerrit-Change-Id: Iab3a6a5f54701470e368c043133f4646aa71126d Gerrit-Change-Number: 21272 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]>
