Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21287 )
Change subject: KUDU-3371 Fix the crash bug when run binaries on older CPU machines ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21287/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21287/1//COMMIT_MSG@15 PS1, Line 15: WITH_SNAPPY nit: Should this be 'PORTABLE'? http://gerrit.cloudera.org:8080/#/c/21287/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/21287/1/thirdparty/build-definitions.sh@1201 PS1, Line 1201: -DPORTABLE=ON \ Considering that this change rocksdb's default behavior and this may cause performance degradation, what about introducing another Kudu building option to set this option when building rocksdb? -- To view, visit http://gerrit.cloudera.org:8080/21287 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id30ae995c41a592fccbdb822bc1f457c5e6878ac Gerrit-Change-Number: 21287 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 15 Apr 2024 09:03:03 +0000 Gerrit-HasComments: Yes
