Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21328 )
Change subject: Allow creating a table with empty range partition ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/common/partition.h@378 PS1, Line 378: Status CreatePartitionsForRange( > This is not an library exported function, why not add the extra parameter t Done http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/common/partition.h@723 PS1, Line 723: HashSchema hash_schema_; > Ditto. Done http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/master/catalog_manager.cc@a2041 PS1, Line 2041: > The comments can be removed now? No, this comments is for the code line 2046 ~ 2050 http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/master/master.proto@578 PS1, Line 578: optional bool allow_empty_partition = 14 [ default = false ]; > Ommit the 'create' word because this structure name (Create...PB) has such Done http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/21328/1/src/kudu/tools/kudu-tool-test.cc@1763 PS1, Line 1763: // Create a new partition. > How about test adding some range partitions to the created table? Done -- To view, visit http://gerrit.cloudera.org:8080/21328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I480072a693e5b6f1a13f86cb1475cff0452472e7 Gerrit-Change-Number: 21328 Gerrit-PatchSet: 2 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Fri, 19 Apr 2024 03:10:21 +0000 Gerrit-HasComments: Yes
