Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19327 )
Change subject: [Tool] KUDU-3318 Compact container metadata file manually ...................................................................... Patch Set 15: (7 comments) http://gerrit.cloudera.org:8080/#/c/19327/8/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/19327/8/src/kudu/fs/log_block_manager.cc@981 PS8, Line 981: Dir* data_dir, > I meant is it correct to update it when read_status is non-OK such as Statu done http://gerrit.cloudera.org:8080/#/c/19327/8/src/kudu/fs/log_block_manager.cc@2987 PS8, Line 2987: "Limiting containers on data directory $0 to $1 blocks", > Oh, yes, I missed it. It in deed has many duplicate code. But a macro 'RETURN_NOT_OK_LBM_DISK_FAILURE_PREPEND' stops me to optimize it. This macro owns a non-static variable 'error_manager_', which can not be used in static function 'GenerateCompactedFile'. http://gerrit.cloudera.org:8080/#/c/19327/14/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/19327/14/src/kudu/fs/log_block_manager.cc@2816 PS14, Line 2816: > This function is similar to the upper part of function CompactLowLiveRatioB done http://gerrit.cloudera.org:8080/#/c/19327/14/src/kudu/fs/log_block_manager.cc@2938 PS14, Line 2938: : return LogBlockContainerNativeMeta::Create(this, dir, container); : } : : Status LogBlockManagerNative > nit: format the code. Done http://gerrit.cloudera.org:8080/#/c/19327/14/src/kudu/fs/log_block_manager.cc@2943 PS14, Line 2943: > Now you are going to delete the files according to the container names, the OK, I will visit all files and delete it if it has the postfix '.offset', '.compacted' and '.backup'. http://gerrit.cloudera.org:8080/#/c/19327/14/src/kudu/fs/log_block_manager.cc@3352 PS14, Line 3352: child, kMetadataOffsetFileSuffix, &container_name)) { > In GetContainerNames implementation, will call GetChildren again which has Done http://gerrit.cloudera.org:8080/#/c/19327/14/src/kudu/fs/log_block_manager.cc@3353 PS14, Line 3353: const stri > nit: Simplify it by using RETURN_NOT_OK_PREPEND Done -- To view, visit http://gerrit.cloudera.org:8080/19327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id61cb6c88d7a093a8448e2497639f5c5c094efa4 Gerrit-Change-Number: 19327 Gerrit-PatchSet: 15 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 19 Apr 2024 09:48:40 +0000 Gerrit-HasComments: Yes
