Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21251 )
Change subject: [rpc-test] make RpcPendingConnectionsMetric more stable ...................................................................... [rpc-test] make RpcPendingConnectionsMetric more stable I noticed that on very fast machines the RpcPendingConnectionsMetric scenario would rarely fail (~1 time per 500 runs) because the sock_diag() netlink facility seemingly reported stale data, i.e. reported one connection was pending while the only attempted connection had already been accepted by the server and even closed by the client. With this test no flakiness has been observed in more than 50K runs of the scenario. Change-Id: If8e66c471452b1e04c84cf2d5c979578c287b4fa Reviewed-on: http://gerrit.cloudera.org:8080/21251 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Mahesh Reddy <[email protected]> Reviewed-by: Abhishek Chennaka <[email protected]> --- M src/kudu/rpc/rpc-test.cc 1 file changed, 23 insertions(+), 9 deletions(-) Approvals: Alexey Serbin: Verified Mahesh Reddy: Looks good to me, but someone else must approve Abhishek Chennaka: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/21251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If8e66c471452b1e04c84cf2d5c979578c287b4fa Gerrit-Change-Number: 21251 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]>
