KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/21316 )
Change subject: [metrics] Add metrics for create and delete op time ...................................................................... Patch Set 5: (6 comments) Thanks a lot for your reviews. http://gerrit.cloudera.org:8080/#/c/21316/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21316/1//COMMIT_MSG@11 PS1, Line 11: The addition of monitoring items will aid in historical issue : tracking and analysis, as well as > Yes: in general that makes sense, of course. I was just trying to say that Thank you for your additional reply. I will update the commit message to provide more specific descriptions of the use cases for these new monitoring items. http://gerrit.cloudera.org:8080/#/c/21316/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21316/4//COMMIT_MSG@11 PS4, Line 11: rical issue : tracking and analysis, as well a > How the stats on the duration of create/delete a tablet replica could help Thank you for your advice, it will indeed be helpful in real-time analysis of issues. Adding this part of operation time monitoring is mainly for historical issue tracking and analysis, as well as facilitating the configuration of monitoring alarms. These require adding new monitoring items to achieve. http://gerrit.cloudera.org:8080/#/c/21316/4/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/21316/4/src/kudu/tserver/ts_tablet_manager.cc@273 PS4, Line 273: .", > What is the significance of this 'on the current node' part? All the table Done http://gerrit.cloudera.org:8080/#/c/21316/4/src/kudu/tserver/ts_tablet_manager.cc@274 PS4, Line 274: kDebu > Why kInfo, not kDebug? Looking at metrics like 'tablets_opening_time_start Done http://gerrit.cloudera.org:8080/#/c/21316/4/src/kudu/tserver/ts_tablet_manager.cc@281 PS4, Line 281: kDebu > ditto: maybe, kDebug is a better choice here? Done http://gerrit.cloudera.org:8080/#/c/21316/4/src/kudu/tserver/ts_tablet_manager.cc@1168 PS4, Line 1168: delete_tablet_run_time_->Increment( > Shouldn't the delete_tablet_run_time_ metric be updated before return here Done -- To view, visit http://gerrit.cloudera.org:8080/21316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02bd52013caa94a33143cb16ff3831a49b74bac4 Gerrit-Change-Number: 21316 Gerrit-PatchSet: 5 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 07 May 2024 09:28:56 +0000 Gerrit-HasComments: Yes
