Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21291 )
Change subject: [metrics] Add tablet level metrics for scans op time ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/21291/4/src/kudu/tablet/tablet_metrics.h File src/kudu/tablet/tablet_metrics.h: http://gerrit.cloudera.org:8080/#/c/21291/4/src/kudu/tablet/tablet_metrics.h@68 PS4, Line 68: scoped_refptr<Histogram> tablet_scans_duration_wall_time; : scoped_refptr<Histogram> tablet_scans_duration_system_time; That's interesting: the system and the wall times are collected, but not the user time. Why? http://gerrit.cloudera.org:8080/#/c/21291/4/src/kudu/tablet/tablet_metrics.cc File src/kudu/tablet/tablet_metrics.cc: http://gerrit.cloudera.org:8080/#/c/21291/4/src/kudu/tablet/tablet_metrics.cc@160 PS4, Line 160: kInfo Here and below: I'm not sure this metric is anything but extra information which might be needed for troubleshooting purposes only: for each active scanner, corresponding information is already displayed at the 'Dashboard' tab of the embedded WebUI. With that, I'd think of kDebug level, not kInfo. http://gerrit.cloudera.org:8080/#/c/21291/4/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/21291/4/src/kudu/tserver/tablet_service.cc@3215 PS4, Line 3215: auto elapsed = scanner_timer.GetElapsed(); There are several earlier returns from this method where scanner times are updated automatically by the scoped-like construct ScopedAddScannerTiming. However, the metrics aren't updated accordingly. Why? -- To view, visit http://gerrit.cloudera.org:8080/21291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f490cfb6f37aef60b34697100fb502374fcc503 Gerrit-Change-Number: 21291 Gerrit-PatchSet: 4 Gerrit-Owner: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Tue, 14 May 2024 22:15:37 +0000 Gerrit-HasComments: Yes
