Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 )
Change subject: [ARM] Concurrent binary tree memory barriers fixed. ...................................................................... Patch Set 13: (7 comments) I updated the review. No more undefined behaviour. I also updated https://docs.google.com/spreadsheets/d/1whl8h7S0DcjVYp0jksR87P9v4U8TQH9nS1C9N0D-lUo/edit?usp=sharing There is a description and a RuntimesSumary tab to understand what it actually contains. It uses "perf stat" now. If the following gerrit passes: https://gerrit.cloudera.org/#/c/21447/ I can add this to the commit message runtimes too when it is merged http://gerrit.cloudera.org:8080/#/c/21127/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21127/3//COMMIT_MSG@9 PS3, Line 9: fail > Maybe add a couple lines about how the failure manifested. Done http://gerrit.cloudera.org:8080/#/c/21127/3//COMMIT_MSG@16 PS3, Line 16: e inserts first, and : only start checking when the tree is finalized does not prevent the > Is this enough to repro the issue on x86 as well? Or only on ARM? Done http://gerrit.cloudera.org:8080/#/c/21127/3//COMMIT_MSG@20 PS3, Line 20: > please add some details on what exactly needs to be changed and what the im Done http://gerrit.cloudera.org:8080/#/c/21127/3//COMMIT_MSG@28 PS3, Line 28: : More info: > Do we know why it does not cause a problem on x86? Done http://gerrit.cloudera.org:8080/#/c/21127/3//COMMIT_MSG@32 PS3, Line 32: olution: > I think this part is a bit hard to understand, I think you are talking abou Done http://gerrit.cloudera.org:8080/#/c/21127/3//COMMIT_MSG@32 PS3, Line 32: > nit: remove Done http://gerrit.cloudera.org:8080/#/c/21127/3//COMMIT_MSG@43 PS3, Line 43: > did you mean "absence of fences"? Done -- To view, visit http://gerrit.cloudera.org:8080/21127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7c02dc3b9444599ef680fa9b29ae7a4d39dd382 Gerrit-Change-Number: 21127 Gerrit-PatchSet: 13 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Anonymous Coward (763) Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 22 May 2024 13:25:10 +0000 Gerrit-HasComments: Yes
