Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19952 )
Change subject: Fix row_project codegen params noalias overflow ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/19952/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19952/5//COMMIT_MSG@9 PS5, Line 9: function->addParamAttr is 0-based indexes, current row_project generator IR code is: : `define i1 @ProjRead(i8* %src, %"class.kudu::RowBlockRow"* noalias %rbrow, %"class.kudu::Arena"* noalias %arena)` > nit: alignment required I'm not going to update this -- this patch is already merged. -- To view, visit http://gerrit.cloudera.org:8080/19952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1dab7d46cff96ed1ebbd020584a066f04e6ca12a Gerrit-Change-Number: 19952 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward <s...@sqh.me> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 22 May 2024 13:53:41 +0000 Gerrit-HasComments: Yes
