Zoltan Martonka has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21447 )

Change subject: Add a benchmark for CBTree concurrent writes.
......................................................................


Patch Set 8:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/21447/7//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21447/7//COMMIT_MSG@29
PS7, Line 29: can't be assig
> nit: can't be assigned
Done


http://gerrit.cloudera.org:8080/#/c/21447/7/src/kudu/tablet/cbtree-test.cc
File src/kudu/tablet/cbtree-test.cc:

http://gerrit.cloudera.org:8080/#/c/21447/7/src/kudu/tablet/cbtree-test.cc@933
PS7, Line 933: t int num_t
> could this be a const?
Done


http://gerrit.cloudera.org:8080/#/c/21447/7/src/kudu/tablet/cbtree-test.cc@936
PS7, Line 936: t int num_inserts_first
> could this be a const?
Done


http://gerrit.cloudera.org:8080/#/c/21447/7/src/kudu/tablet/cbtree-test.cc@1089
PS7, Line 1089:
> nit: extra space
Done



--
To view, visit http://gerrit.cloudera.org:8080/21447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b0b16e269c70716962fc5ebb4ddca1e2cbe68a4
Gerrit-Change-Number: 21447
Gerrit-PatchSet: 8
Gerrit-Owner: Zoltan Martonka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
Gerrit-Comment-Date: Wed, 29 May 2024 13:25:42 +0000
Gerrit-HasComments: Yes

Reply via email to