Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 )
Change subject: KUDU-613: Introduce SLRU cache ...................................................................... Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/20607/18/src/kudu/util/slru_cache.cc File src/kudu/util/slru_cache.cc: http://gerrit.cloudera.org:8080/#/c/20607/18/src/kudu/util/slru_cache.cc@188 PS18, Line 188: UpdateMemTracker(-static_cast<int64_t>(e->charge)); : if (PREDICT_TRUE(metrics_)) { : metrics_->cache_usage->DecrementBy(e->charge); : metrics_->evictions->Increment(); : } Is it possible to avoid code repetition here and SoftFreeEntry()? -- To view, visit http://gerrit.cloudera.org:8080/20607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45531534a2049dd38c002f4dc7982df9fd46e0bb Gerrit-Change-Number: 20607 Gerrit-PatchSet: 18 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 29 May 2024 18:35:24 +0000 Gerrit-HasComments: Yes
