Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/21030 )
Change subject: [build] KUDU-3551 Upgrade gradle to 7.6.4 ...................................................................... Patch Set 21: (3 comments) http://gerrit.cloudera.org:8080/#/c/21030/21/java/build.gradle File java/build.gradle: http://gerrit.cloudera.org:8080/#/c/21030/21/java/build.gradle@a72 PS21, Line 72: > is this not needed anymore? I'll do some testing to confirm http://gerrit.cloudera.org:8080/#/c/21030/20/java/gradle/publishing.gradle File java/gradle/publishing.gradle: http://gerrit.cloudera.org:8080/#/c/21030/20/java/gradle/publishing.gradle@72 PS20, Line 72: } > nit: add an empty line Done http://gerrit.cloudera.org:8080/#/c/21030/21/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala: http://gerrit.cloudera.org:8080/#/c/21030/21/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@238 PS21, Line 238: // setting up log capture for the class that generates the logs we're > nit: Capitalize and add a period at the end of the sentence like the others Done -- To view, visit http://gerrit.cloudera.org:8080/21030 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I915dab011aba633d55a79c72ea6f459d703d7f47 Gerrit-Change-Number: 21030 Gerrit-PatchSet: 21 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Fri, 07 Jun 2024 12:53:09 +0000 Gerrit-HasComments: Yes
