Marton Greber has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21496 )

Change subject: Include table UUID when using --show_table_info
......................................................................


Patch Set 1:

(1 comment)

Can you also take a look whether this change breaks any of the kudu-tool-tests?
http://dist-test.cloudera.org/job?job_id=jenkins-slave.1718036242.523024
In kudu-tool-test.2: "Bad status: Not found: the table does not exist: 
table_name: "id:  name: kudu.table_0"" <- eg is this expected? (i assume in the 
test we are matching against table name)
Thank you!

http://gerrit.cloudera.org:8080/#/c/21496/1/src/kudu/tools/tool_action_table.cc
File src/kudu/tools/tool_action_table.cc:

http://gerrit.cloudera.org:8080/#/c/21496/1/src/kudu/tools/tool_action_table.cc@123
PS1, Line 123: DEFINE_bool(show_table_info, false,
             :             "Include extra information such as number of 
tablets, replicas, "
             :             "and live row count for a table in the output");
Can you please extend this description to include the newly added table id?



--
To view, visit http://gerrit.cloudera.org:8080/21496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I324b920e6feb6139e7d884e3cf08069b0cb922a4
Gerrit-Change-Number: 21496
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
Gerrit-Comment-Date: Tue, 11 Jun 2024 08:33:46 +0000
Gerrit-HasComments: Yes

Reply via email to