Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 )
Change subject: KUDU-613: Introduce SLRU cache ...................................................................... Patch Set 22: Code-Review+2 > (4 comments) > > Created new SLRUHandle to mimic RLHandle to resolve the ASAN > issues. Any new field in the RLHandle resulted in ASAN issues in > codegen. I guess the issue with ASAN is a thing on its own. I was suspecting a conflict with cache implementation from rocksdb library (Kudu picked up its cache implementation from LevelDB a long time ago), but Mahesh confirmed that rolling back https://gerrit.cloudera.org/c/21075/ didn't help to resolve the problem. Apart from that, I think this patch looks good enough. There were several follow-up candidates to address, but as of PS22 this looks OK. -- To view, visit http://gerrit.cloudera.org:8080/20607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45531534a2049dd38c002f4dc7982df9fd46e0bb Gerrit-Change-Number: 20607 Gerrit-PatchSet: 22 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 11 Jun 2024 21:54:10 +0000 Gerrit-HasComments: No
