Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/21527 )
Change subject: [Tool] Limit table copying speed ...................................................................... Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/21527/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21527/1//COMMIT_MSG@10 PS1, Line 10: When nit: when http://gerrit.cloudera.org:8080/#/c/21527/1//COMMIT_MSG@9 PS1, Line 9: using CLI command : 'kudu table copy' reword: using the 'kudu table copy' CLI command http://gerrit.cloudera.org:8080/#/c/21527/1//COMMIT_MSG@10 PS1, Line 10: it nit: 'it' not needed http://gerrit.cloudera.org:8080/#/c/21527/1//COMMIT_MSG@11 PS1, Line 11: memory pressure or run out the network bandwidth. memory and/or network bandwidth perssure http://gerrit.cloudera.org:8080/#/c/21527/1//COMMIT_MSG@12 PS1, Line 12: affect on other service effect on other services http://gerrit.cloudera.org:8080/#/c/21527/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/21527/1/src/kudu/tools/kudu-tool-test.cc@5942 PS1, Line 5942: cluster_->master()->bound_rpc_addr().ToString() consider extracting this to it's own variable as it is used multiple times in the test, e.g. string master_addr = cluster_->master()->bound_rpc_addr().ToString(); http://gerrit.cloudera.org:8080/#/c/21527/1/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/21527/1/src/kudu/tools/table_scanner.cc@150 PS1, Line 150: maximun nit:maximum http://gerrit.cloudera.org:8080/#/c/21527/1/src/kudu/tools/table_scanner.cc@150 PS1, Line 150: equals nit:equal -- To view, visit http://gerrit.cloudera.org:8080/21527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37d23f6f5158618f91b67528e152cf2ff4cf38f3 Gerrit-Change-Number: 21527 Gerrit-PatchSet: 1 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 20 Jun 2024 09:56:04 +0000 Gerrit-HasComments: Yes
