Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21507 )
Change subject: [metrics] Add metrics for tablet replication time ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21507/1/src/kudu/tablet/tablet_replica-test.cc File src/kudu/tablet/tablet_replica-test.cc: http://gerrit.cloudera.org:8080/#/c/21507/1/src/kudu/tablet/tablet_replica-test.cc@782 PS1, Line 782: unique_ptr<WriteRequestPB> req(new WriteRequestPB()); nit: auto req = std::make_unique<WriteRequestPB>(); https://stackoverflow.com/questions/37514509/advantages-of-using-stdmake-unique-over-new-operator -- To view, visit http://gerrit.cloudera.org:8080/21507 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ea89c3954ceecabdb2998d2a8945f12a2fb8aa9 Gerrit-Change-Number: 21507 Gerrit-PatchSet: 1 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 21 Jun 2024 07:35:33 +0000 Gerrit-HasComments: Yes
