Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/21580 )
Change subject: [client] add ScanTokenStaleRaftMembershipTest ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21580/1/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/21580/1/src/kudu/client/scan_token-test.cc@1590 PS1, Line 1590: // ??? nit: Remove http://gerrit.cloudera.org:8080/#/c/21580/1/src/kudu/client/scan_token-test.cc@1702 PS1, Line 1702: ASSERT_OK(LeaderStepDown(tsd, tablet_id, MonoDelta::FromSeconds(30))); Do you think it would makes sense to add an assert to verify the new_leader_uuid matches with leader uuid? -- To view, visit http://gerrit.cloudera.org:8080/21580 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ce3d549d4ab2502c58deae1250b49ba16bbc914 Gerrit-Change-Number: 21580 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 12 Jul 2024 12:55:59 +0000 Gerrit-HasComments: Yes
