Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21580 )
Change subject: [client] add ScanTokenStaleRaftMembershipTest ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21580/3/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/21580/3/src/kudu/client/scan_token-test.cc@1699 PS3, Line 1699: During the Raft election round, WriteRequestPB : // RPCs should be rejected with REPLICA_NOT_LEADER error code by every replica : // of the tablet > nit: Maybe put an ASSERT_STR_CONTAINS for "is not leader of this config" he That functionality is already covered by other test scenarios, and this isn't quite crucial for this scenario, so I'm not going to duplicate the test coverage here. -- To view, visit http://gerrit.cloudera.org:8080/21580 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ce3d549d4ab2502c58deae1250b49ba16bbc914 Gerrit-Change-Number: 21580 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 16 Jul 2024 00:59:49 +0000 Gerrit-HasComments: Yes
