Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21527 )
Change subject: [Tool] Limit table copying speed ...................................................................... Patch Set 6: (9 comments) I'm not sure this works as expected in PS6. http://gerrit.cloudera.org:8080/#/c/21527/6/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/21527/6/src/kudu/tools/kudu-tool-test.cc@6011 PS6, Line 6011: 10240 Are you sure this is small enough to track copying of 20000 rows, especially of the data is compressed? http://gerrit.cloudera.org:8080/#/c/21527/6/src/kudu/tools/kudu-tool-test.cc@6029 PS6, Line 6029: client->OpenTable(kNewTableName, &table); Wrap this into ASSERT_OK()? http://gerrit.cloudera.org:8080/#/c/21527/6/src/kudu/tools/kudu-tool-test.cc@6031 PS6, Line 6031: scanner.Open(); Wrap this into ASSERT_OK()? http://gerrit.cloudera.org:8080/#/c/21527/6/src/kudu/tools/kudu-tool-test.cc@6036 PS6, Line 6036: = Shouldn't this be '+=' instead of '='? With the current code, the assertion at 6039 doesn't make much sense if 'data_size' just tracks the size of the very last batch. http://gerrit.cloudera.org:8080/#/c/21527/6/src/kudu/tools/kudu-tool-test.cc@6038 PS6, Line 6038: must nit: must be http://gerrit.cloudera.org:8080/#/c/21527/6/src/kudu/tools/table_scanner.h File src/kudu/tools/table_scanner.h: http://gerrit.cloudera.org:8080/#/c/21527/6/src/kudu/tools/table_scanner.h@107 PS6, Line 107: std::shared_ptr Why shared_ptr? There isn't any shared ownership for this field, this is solely own by TableScanner instance. Should this be std::unique_ptr instead? http://gerrit.cloudera.org:8080/#/c/21527/6/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/21527/6/src/kudu/tools/table_scanner.cc@611 PS6, Line 611: copy nit: copying http://gerrit.cloudera.org:8080/#/c/21527/6/src/kudu/tools/table_scanner.cc@613 PS6, Line 613: SCOPED_LOG_SLOW_EXECUTION What's the purpose of this warning? If the idea was to track cases when it takes a long time to consume a throttler's token, semantically that seems closer to INFO, not WARNING since it's expected to throttle as configured. http://gerrit.cloudera.org:8080/#/c/21527/6/src/kudu/tools/table_scanner.cc@614 PS6, Line 614: 0 Why 0? Isn't this a typo? Would be great to at least add a comment on this -- I'd expect this to be at least 1. -- To view, visit http://gerrit.cloudera.org:8080/21527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37d23f6f5158618f91b67528e152cf2ff4cf38f3 Gerrit-Change-Number: 21527 Gerrit-PatchSet: 6 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Fri, 19 Jul 2024 18:18:27 +0000 Gerrit-HasComments: Yes
