Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/21030 )
Change subject: [build] KUDU-3551 Upgrade gradle to 7.6.4 ...................................................................... Patch Set 26: (2 comments) http://gerrit.cloudera.org:8080/#/c/21030/25/java/buildSrc/build.gradle File java/buildSrc/build.gradle: http://gerrit.cloudera.org:8080/#/c/21030/25/java/buildSrc/build.gradle@30 PS25, Line 30: implementation "gradle.plugin.com.github.johnrengelman:shadow:7.1.2" > This version update isn't mentioned in the commit message. Good catch, fixed http://gerrit.cloudera.org:8080/#/c/21030/25/java/kudu-backup/build.gradle File java/kudu-backup/build.gradle: http://gerrit.cloudera.org:8080/#/c/21030/25/java/kudu-backup/build.gradle@55 PS25, Line 55: shadowJar { > Why is this section added? Otherwise the generated jars blow up in size. Without these, e.g the kudu-client jar created is ~350Mbs. -- To view, visit http://gerrit.cloudera.org:8080/21030 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I915dab011aba633d55a79c72ea6f459d703d7f47 Gerrit-Change-Number: 21030 Gerrit-PatchSet: 26 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 24 Jul 2024 08:17:55 +0000 Gerrit-HasComments: Yes
