Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21601 )
Change subject: KUDU-613: SLRU Cache Benchmark ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21601/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21601/1//COMMIT_MSG@18 PS1, Line 18: Ran benchmarks for RELEASE build locally on macOS. : 6 cores and 2.6GHz. > Added those stats as well. Note, the SLRU cache doesn't perform well at all Thank you for updating the information on the benchmark results. So, the current 80/20 was flipped from 20/80 ratio to see at least some gain in the new pattern, and otherwise the results were not so advantageous for the SLRU? With this, it seems we will need to compare the cache hit ratios between the LRU and SLRU cache against some real workloads. http://gerrit.cloudera.org:8080/#/c/21601/2/src/kudu/util/cache-bench.cc File src/kudu/util/cache-bench.cc: http://gerrit.cloudera.org:8080/#/c/21601/2/src/kudu/util/cache-bench.cc@193 PS2, Line 193: often.exchange(!often) I'm just curious: why to introduce this extra uncertainty? Wouldn't it be more predictable to know how many threads doing repeatable look-ups, and how many do otherwise? >From the other hand, if the idea was to introduce 'hybrid' behavior in the >behavior in each of the threads, then maybe remove this parameter and move the >flipping between two different behavior flavors inside the DoQueries() >function? -- To view, visit http://gerrit.cloudera.org:8080/21601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c128a9f047497373ce3e740056eaa89a352261b Gerrit-Change-Number: 21601 Gerrit-PatchSet: 2 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Fri, 26 Jul 2024 22:48:14 +0000 Gerrit-HasComments: Yes
