Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21631 )
Change subject: [cfile] make WriterOptions* a constant member field ...................................................................... Patch Set 1: Code-Review+1 (2 comments) just a few nits, looks good otherwise. http://gerrit.cloudera.org:8080/#/c/21631/1/src/kudu/cfile/plain_bitmap_block.h File src/kudu/cfile/plain_bitmap_block.h: http://gerrit.cloudera.org:8080/#/c/21631/1/src/kudu/cfile/plain_bitmap_block.h@48 PS1, Line 48: writer nit: spacing is off http://gerrit.cloudera.org:8080/#/c/21631/1/src/kudu/cfile/rle_block.h File src/kudu/cfile/rle_block.h: http://gerrit.cloudera.org:8080/#/c/21631/1/src/kudu/cfile/rle_block.h@229 PS1, Line 229: rle_encoder nit: spacing is off -- To view, visit http://gerrit.cloudera.org:8080/21631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a209194a15d9d49bbd42949223651b0fd17c7c0 Gerrit-Change-Number: 21631 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 05 Aug 2024 18:57:01 +0000 Gerrit-HasComments: Yes
