Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21670 )
Change subject: [cfile] modernize CFileWriter ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21670/2/src/kudu/cfile/cfile_writer.cc File src/kudu/cfile/cfile_writer.cc: http://gerrit.cloudera.org:8080/#/c/21670/2/src/kudu/cfile/cfile_writer.cc@354 PS2, Line 354: const uint32_t num_elems_in_block = > Why is it uint32_t and not size_t (or maybe rowid_t)? I guess that's because of line 386. Factually, the maximum number of rows per block is 2^32. I'd prefer to keep this as-is because it's important to keep the argument for PutVarint32 to be explicitly 32-bit integer. -- To view, visit http://gerrit.cloudera.org:8080/21670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6038de39f912b054320b97af11145627c68ba00a Gerrit-Change-Number: 21670 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Thu, 15 Aug 2024 17:49:14 +0000 Gerrit-HasComments: Yes
